Refactored cont.index.R and created testcase #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Helge Hecht <helge.hecht@recetox.muni.cz>
Co-authored-by: Helge Hecht <helge.hecht@recetox.muni.cz>
Co-authored-by: Helge Hecht <helge.hecht@recetox.muni.cz>
Co-authored-by: Helge Hecht <helge.hecht@recetox.muni.cz>
hechth
reviewed
Nov 1, 2022
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
xtrojak
reviewed
Nov 2, 2022
tests/testthat/test-run_filter.R
Outdated
| if(ci_skip == TRUE) skip_on_ci() | ||
|
|
||
| testdata <- file.path("..", "testdata") | ||
| input_path <- file.path(testdata, "input", filename) |
There was a problem hiding this comment.
There are only mzml files in input directory. Maybe you meant filtered? This is related to CI error:
── Error ('test-run_filter.R:9'): test run_filter mbr_test0 ────────────────────
Error: IOError: Failed to open local file '../testdata/input/mbr_test0.parquet'. Detail: [errno 2] No such file or directory
Backtrace:
▆
1. ├─rlang::eval_tidy(code, args)
2. ├─base::as.matrix(arrow::read_parquet(input_path)) at test-run_filter.R:9:4
3. └─arrow::read_parquet(input_path)
4. └─arrow:::make_readable_file(file)
5. └─arrow::mmap_open(file)
6. └─arrow:::io___MemoryMappedFile__Open(path, mode)
There was a problem hiding this comment.
The test file has been updated to the folder containing the input file (~/filtered/run_filter/). [7a81c10]
|
The reason why tests fail is because the testdata is already updated for merging the pr #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #111