-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored cont.index.R and created testcase #156
Conversation
Co-authored-by: Helge Hecht <helge.hecht@recetox.muni.cz>
Co-authored-by: Helge Hecht <helge.hecht@recetox.muni.cz>
Co-authored-by: Helge Hecht <helge.hecht@recetox.muni.cz>
Co-authored-by: Helge Hecht <helge.hecht@recetox.muni.cz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @wverastegui !
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
tests/testthat/test-run_filter.R
Outdated
if(ci_skip == TRUE) skip_on_ci() | ||
|
||
testdata <- file.path("..", "testdata") | ||
input_path <- file.path(testdata, "input", filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only mzml
files in input
directory. Maybe you meant filtered
? This is related to CI error:
── Error ('test-run_filter.R:9'): test run_filter mbr_test0 ────────────────────
Error: IOError: Failed to open local file '../testdata/input/mbr_test0.parquet'. Detail: [errno 2] No such file or directory
Backtrace:
▆
1. ├─rlang::eval_tidy(code, args)
2. ├─base::as.matrix(arrow::read_parquet(input_path)) at test-run_filter.R:9:4
3. └─arrow::read_parquet(input_path)
4. └─arrow:::make_readable_file(file)
5. └─arrow::mmap_open(file)
6. └─arrow:::io___MemoryMappedFile__Open(path, mode)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test file has been updated to the folder containing the input file (~/filtered/run_filter/). [7a81c10]
The reason why tests fail is because the testdata is already updated for merging the pr #154 |
Close #111